GH-607: Specify handling for unrecognized logical types - #606
Merged
Conversation
divjotarora
changed the title
emkornfield
approved these changes
Aug 13, 2026
emkornfield
left a comment
emkornfield
left a comment
Contributor
There was a problem hiding this comment.
Thanks for officially documenting this.
alamb
approved these changes
Aug 31, 2026
alamb
left a comment
alamb
left a comment
Contributor
There was a problem hiding this comment.
Makes sense to me -- thank you @divjotarora
It may also make sense to put a note / link to this section from the main contributing guide where this is explicitly mentioned:
parquet-format/CONTRIBUTING.md
Line 129 in e94a5d0
Contributor
Author
Nice catch @alamb, updated! |
prtkgaur
approved these changes
Sep 1, 2026
wgtmac
approved these changes
Sep 2, 2026
Fokko
approved these changes
Sep 3, 2026
nssalian
approved these changes
Sep 3, 2026
RussellSpitzer
approved these changes
Sep 3, 2026
zhangfengcdt
approved these changes
Sep 3, 2026
rdblue
approved these changes
Sep 3, 2026
Contributor
|
Vote passed, moving this forward: https://lists.apache.org/thread/f1qgt2x0gg8ybwgcgshc67k1hso5t2qd Thanks @divjotarora and everyone who participated 👍 |
Contributor
|
🙏 Thanks @divjotarora and @Fokko |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
11 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Rationale for this change
We currently do not specify how readers should handle unrecognized logical types or logical/physical type combinations.
What changes are included in this PR?
Specify that unrecognized logical types or logical/physical type combinations should result in both the logical type annotation and stats being ignored.
Do these changes have PoC implementations?
parquet-java reference implementation